Skip to content

fix: ci - #261

Merged
ns-vasilev merged 7 commits into
mainfrom
fix/ci
Nov 6, 2026
Merged

ns-vasilev merged 7 commits into
mainfrom
fix/ci

Conversation

@ns-vasilev

Copy link
Copy Markdown
Member

No description provided.

ns-vasilev and others added 2 commits November 6, 2026 13:57
danger 9.6.1 fails with git 5.x (uninitialized constant Git::Base).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ns-vasilev ns-vasilev self-assigned this Nov 6, 2026
@ns-vasilev
ns-vasilev requested a review from a team as a code owner November 6, 2026 09:59
@spacecode-github-bot

spacecode-github-bot commented Nov 6, 2026 •

Copy link
Copy Markdown
3 Warnings
⚠️

⚠️ Some source files are missing corresponding test files:

  • Logger → expected test file: LoggerTests.swift
  • Types → expected test file: TypesTests.swift
  • Strings → expected test file: StringsTests.swift
  • PaymentQueue → expected test file: PaymentQueueTests.swift
  • TransactionListener → expected test file: TransactionListenerTests.swift
  • DiscountType → expected test file: DiscountTypeTests.swift
  • ExpirationReason → expected test file: ExpirationReasonTests.swift
  • PaymentMode → expected test file: PaymentModeTests.swift
  • PriceIncreaseStatus → expected test file: PriceIncreaseStatusTests.swift
  • RefundError → expected test file: RefundErrorTests.swift
  • RefundRequestStatus → expected test file: RefundRequestStatusTests.swift
  • RenewalInfo → expected test file: RenewalInfoTests.swift
  • SubscriptionInfo → expected test file: SubscriptionInfoTests.swift
  • SubscriptionPeriod → expected test file: SubscriptionPeriodTests.swift
  • VerificationError → expected test file: VerificationErrorTests.swift
  • ReceiptRefreshRequestFactory → expected test file: ReceiptRefreshRequestFactoryTests.swift
  • Value → expected test file: ValueTests.swift
  • Colors → expected test file: ColorsTests.swift
  • Media → expected test file: MediaTests.swift
  • Strings → expected test file: StringsTests.swift
  • ProductViewController → expected test file: ProductViewControllerTests.swift
  • AutomaticSubscriptionControlStyle → expected test file: AutomaticSubscriptionControlStyleTests.swift
  • ButtonSubscriptionStoreControlStyle → expected test file: ButtonSubscriptionStoreControlStyleTests.swift
  • PickerSubscriptionStoreControlStyleView → expected test file: PickerSubscriptionStoreControlStyleViewTests.swift
  • ProductPlaceholderView → expected test file: ProductPlaceholderViewTests.swift
  • AutomaticPoliciesButtonStyle → expected test file: AutomaticPoliciesButtonStyleTests.swift
  • ProductInfoView → expected test file: ProductInfoViewTests.swift
  • AutomaticSubscriptionsWrapperViewStyle → expected test file: AutomaticSubscriptionsWrapperViewStyleTests.swift
  • SubscriptionsViewModelViewFactory → expected test file: SubscriptionsViewModelViewFactoryTests.swift
⚠️ New dependency added but README not updated
⚠️ Public API changed but no documentation updates found
6 Messages
📖 📦 Package.swift was modified - please ensure:
📖
  • Dependencies are pinned to specific versions
📖
  • New dependencies are documented in README
📖
  • Platform requirements are correct
📖 ⚠️ Generated files were modified: Sources/Flare/Classes/Generated/Strings.swift, Sources/FlareUI/Classes/Generated/Colors.swift, Sources/FlareUI/Classes/Generated/Media.swift, Sources/FlareUI/Classes/Generated/Strings.swift
📖 Please verify these changes are intentional

Generated by 🚫 Danger

@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.09091% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.60%. Comparing base (f27d8e7) to head (87be30b).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rces/Flare/Classes/Models/SubscriptionPeriod.swift 40.00% 6 Missing ⚠️
...sses/Providers/RefundProvider/RefundProvider.swift 0.00% 4 Missing ⚠️
Sources/FlareUI/Classes/Core/Helpers/Value.swift 25.00% 3 Missing ⚠️
...tyle/PickerSubscriptionStoreControlStyleView.swift 33.33% 2 Missing ⚠️
...ciesButtonStyle/AutomaticPoliciesButtonStyle.swift 0.00% 2 Missing ⚠️
...ptionsView/SubscriptionsViewModelViewFactory.swift 0.00% 2 Missing ⚠️
...lasses/Extensions/Locale/Locale+CurrencyCode.swift 50.00% 1 Missing ⚠️
Sources/Flare/Classes/Models/DiscountType.swift 66.67% 1 Missing ⚠️
Sources/Flare/Classes/Models/PaymentMode.swift 75.00% 1 Missing ⚠️
...ntrolStyle/AutomaticSubscriptionControlStyle.swift 50.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   68.33%   67.60%   -0.73%     
==========================================
  Files         319      319              
  Lines        8086     7917     -169     
==========================================
- Hits         5525     5352     -173     
- Misses       2561     2565       +4     
Files with missing lines Coverage Δ
Sources/Flare/Classes/Common/Logger.swift 88.24% <100.00%> (-1.24%) ⬇️
Sources/Flare/Classes/Extensions/SKProduct+.swift 100.00% <ø> (ø)
...lare/Classes/Extensions/SKRequest+Identifier.swift 100.00% <ø> (ø)
Sources/Flare/Classes/Flare.swift 73.08% <ø> (ø)
Sources/Flare/Classes/Generated/Strings.swift 46.05% <100.00%> (-1.38%) ⬇️
...re/Classes/Helpers/PaymentQueue/PaymentQueue.swift 71.43% <ø> (-14.29%) ⬇️
...ers/PaymentQueue/SKPaymentQueue+PaymentQueue.swift 100.00% <ø> (ø)
...elpers/PaymentTransaction/PaymentTransaction.swift 89.80% <ø> (ø)
...are/Classes/Helpers/ProcessInfo/ProcessInfo+.swift 100.00% <ø> (ø)
Sources/Flare/Classes/IFlare.swift 66.67% <ø> (ø)
... and 73 more

... and 21 files with indirect coverage changes

ns-vasilev and others added 5 commits November 6, 2026 14:02
macos-14-arm64 configuration is no longer supported. Xcode 15.x is not
available on macOS 15 images, so the Swift 5.10 / iOS 17 legs are dropped.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
{created.year} depends on git history and flakily resolves to the
current year on CI, failing the fileHeader rule.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… 18.5, watchOS 11.5)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ns-vasilev
ns-vasilev merged commit c023413 into main Nov 6, 2026
13 of 16 checks passed
@ns-vasilev
ns-vasilev deleted the fix/ci branch November 6, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants